Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: proto conversions for BucketAccessControl #4247

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented May 20, 2020

Fixes #4174


This change is Reviewable

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. labels May 20, 2020
@coryan coryan marked this pull request as ready for review May 20, 2020 21:12
@coryan coryan requested a review from a team as a code owner May 20, 2020 21:12
@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #4247 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4247      +/-   ##
==========================================
- Coverage   93.39%   93.37%   -0.03%     
==========================================
  Files         862      862              
  Lines       66926    66991      +65     
==========================================
+ Hits        62508    62553      +45     
- Misses       4418     4438      +20     
Impacted Files Coverage Δ
google/cloud/storage/bucket_access_control.h 100.00% <ø> (ø)
google/cloud/storage/internal/grpc_client.h 100.00% <ø> (ø)
google/cloud/storage/internal/grpc_client.cc 96.61% <100.00%> (+0.19%) ⬆️
...orage/internal/grpc_client_bucket_metadata_test.cc 100.00% <100.00%> (ø)
google/cloud/storage/hashing_options.h 62.50% <0.00%> (-37.50%) ⬇️
google/cloud/storage/oauth2/credentials.h 33.33% <0.00%> (-33.34%) ⬇️
google/cloud/storage/download_options.h 81.81% <0.00%> (-18.19%) ⬇️
google/cloud/storage/internal/curl_handle.h 50.00% <0.00%> (-18.19%) ⬇️
google/cloud/storage/upload_options.h 83.33% <0.00%> (-16.67%) ⬇️
...storage/benchmarks/storage_throughput_benchmark.cc 82.54% <0.00%> (-6.81%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16e6684...5d8fdae. Read the comment docs.

@coryan coryan merged commit a78049f into googleapis:master May 20, 2020
@coryan coryan deleted the feat-grpc-to-from-proto-bucketaccesscontrol branch May 20, 2020 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create ToProto/FromProto for storage::BucketAccessControl
3 participants