This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
fix: Value::op==() correctly handles Date and Timestamp #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops. It looks like we forgot to teach Value::op== how to compare Date and Timestamps. Now it's fixed, and I added a test to make sure basic Value equality works for all "kinds".
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1386 +/- ##
==========================================
+ Coverage 94.58% 94.59% +<.01%
==========================================
Files 185 186 +1
Lines 15316 15329 +13
==========================================
+ Hits 14487 14500 +13
Misses 829 829
Continue to review full report at Codecov.
|
coryan
approved these changes
Mar 16, 2020
devjgm
added a commit
to devjgm/google-cloud-cpp
that referenced
this pull request
May 7, 2020
…oogle-cloud-cpp-spanner#1386) Oops. It looks like we forgot to teach Value::op== how to compare Date and Timestamps. Now it's fixed, and I added a test to make sure basic Value equality works for all "kinds".
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oops. It looks like we forgot to teach Value::op== how to compare Date
and Timestamps. Now it's fixed, and I added a test to make sure basic
Value equality works for all "kinds".
This change is