Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

feat: add a Commit() helper that takes the Mutations directly #1319

Merged
merged 2 commits into from
Feb 28, 2020

Conversation

devbww
Copy link
Contributor

@devbww devbww commented Feb 28, 2020

This convenience function saves the user from having to create a
small, but non-trivial lambda.

Fixes #1315.


This change is Reviewable

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 28, 2020
@devbww devbww marked this pull request as ready for review February 28, 2020 06:06
@devbww devbww requested a review from devjgm February 28, 2020 06:06
Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @devjgm)

Copy link
Contributor

@devjgm devjgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One optional documentation suggestion, but otherwise LGTM, thanks.

google/cloud/spanner/client.h Outdated Show resolved Hide resolved
This convenience function saves the user from having to create a
small, but non-trivial lambda.
Copy link
Contributor

@devjgm devjgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replied with my vote, but I'm happy for you to decide. Approving now so you're not blocked on me.

google/cloud/spanner/client.h Outdated Show resolved Hide resolved
@devbww devbww merged commit 4375133 into googleapis:master Feb 28, 2020
@devbww devbww deleted the commit-mutations branch February 28, 2020 20:20
devjgm pushed a commit to devjgm/google-cloud-cpp that referenced this pull request May 7, 2020
…ogleapis/google-cloud-cpp-spanner#1319)

This convenience function saves the user from having to create a
small, but non-trivial lambda.

Fixes googleapis/google-cloud-cpp-spanner#1315.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider: Client::Commit(Mutations)
4 participants