This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the existing test to verify the installed version of the libraries was usable with an example (which also tests the same thing). This example can be a good starting point for application developers that want to create Bazel or CMake projects using google-cloud-cpp-spanner. Most of the changes are in the CI scripts to actually compile this new example.
devjgm
reviewed
Feb 28, 2020
quickstart/README.md
Outdated
@@ -0,0 +1,49 @@ | |||
# HOWTO: usie google-cloud-cpp-spanner in your project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: "usie"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
PTAL |
devjgm
approved these changes
Feb 28, 2020
devjgm
approved these changes
Feb 28, 2020
This was referenced Feb 28, 2020
devjgm
pushed a commit
to devjgm/google-cloud-cpp
that referenced
this pull request
May 7, 2020
…er#1318) Refactor the existing test to verify the installed version of the libraries was usable with an example (which also tests the same thing). This example can be a good starting point for application developers that want to create Bazel or CMake projects using google-cloud-cpp-spanner. Most of the changes are in the CI scripts to actually compile this new example.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the existing test to verify the installed version of the
libraries was usable with an example (which also tests the same thing).
This example can be a good starting point for application developers
that want to create Bazel or CMake projects using google-cloud-cpp-spanner.
Most of the changes are in the CI scripts to actually compile this
new example.
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)