This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
feat: environment-variable override of the spanner endpoint #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `SPANNER_EMULATOR_HOST` environment variable is set, the
endpoint/credentials for data and admin connections are overridden
by `${SPANNER_EMULATOR_HOST}` and `grpc::InsecureChannelCredentials()`
respectively.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1269 +/- ##
==========================================
+ Coverage 94.8% 94.85% +0.05%
==========================================
Files 181 181
Lines 13789 13827 +38
==========================================
+ Hits 13073 13116 +43
+ Misses 716 711 -5
Continue to review full report at Codecov.
|
devjgm
approved these changes
Feb 18, 2020
devjgm
reviewed
Feb 19, 2020
devjgm
pushed a commit
to devjgm/google-cloud-cpp
that referenced
this pull request
May 7, 2020
…is/google-cloud-cpp-spanner#1269) When the `SPANNER_EMULATOR_HOST` environment variable is set, the endpoint/credentials for data and admin connections are overridden by `${SPANNER_EMULATOR_HOST}` and `grpc::InsecureChannelCredentials()` respectively. Fixes googleapis/google-cloud-cpp-spanner#1200.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
SPANNER_EMULATOR_HOSTenvironment variable is set, theendpoint and credentials for data and admin connections are overridden
by
${SPANNER_EMULATOR_HOST}andgrpc::InsecureChannelCredentials()respectively.
This change is