Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

chore: upgrade to cpp-cmakefiles v0.4.1 #1253

Merged
merged 2 commits into from
Feb 7, 2020

Conversation

devbww
Copy link
Contributor

@devbww devbww commented Feb 7, 2020

This change is Reviewable

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 7, 2020
@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

Merging #1253 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1253      +/-   ##
==========================================
- Coverage   94.95%   94.94%   -0.01%     
==========================================
  Files         185      185              
  Lines       13825    13824       -1     
==========================================
- Hits        13127    13125       -2     
- Misses        698      699       +1
Impacted Files Coverage Δ
...on_tests/rpc_failure_threshold_integration_test.cc 85.71% <0%> (-2.07%) ⬇️
google/cloud/spanner/value.h 92.8% <0%> (-0.11%) ⬇️
.../spanner/benchmarks/multiple_rows_cpu_benchmark.cc 92.36% <0%> (-0.01%) ⬇️
...anner/integration_tests/client_integration_test.cc 98.47% <0%> (-0.01%) ⬇️
google/cloud/spanner/keys.h 100% <0%> (ø) ⬆️
google/cloud/spanner/internal/polling_loop.h 94.59% <0%> (+2.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9fc6de...a30b653. Read the comment docs.

@devbww devbww marked this pull request as ready for review February 7, 2020 05:37
@devbww devbww requested a review from coryan February 7, 2020 05:38
Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in the other PR, I think we should update the Bazel SHA-1 version for googleapis at the same time.

Reviewed 13 of 13 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


ci/test-api/spanner_client.expected.abi.dump.gz, line 0 at r1 (raw file):
FYI, I see you update these files in almost every commit. Note that the dump is not deterministic (basically it is a perl hash table dump in ASCII format, the order of the entries can and does change from run to run), even when the contents are semantically equivalent.

Copy link
Contributor Author

@devbww devbww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you say "at the same time" here. OK, I'll do that.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor Author

@devbww devbww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


ci/test-api/spanner_client.expected.abi.dump.gz, line at r1 (raw file):

Previously, coryan (Carlos O'Ryan) wrote…

FYI, I see you update these files in almost every commit. Note that the dump is not deterministic (basically it is a perl hash table dump in ASCII format, the order of the entries can and does change from run to run), even when the contents are semantically equivalent.

Yeah. Unfortunately the results of the "check-api" are often long gone by the time I go to make a commit (and I'm not sure how to determine semantic equivalency without a re-run), and then I often simply forget that the dump is in the staged files. Perhaps we should just avoid updates altogether except for release time.

Copy link
Contributor Author

@devbww devbww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. PTAL. Thanks.

Reviewable status: 13 of 15 files reviewed, all discussions resolved

Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@devbww devbww merged commit 01f634f into googleapis:master Feb 7, 2020
@devbww devbww deleted the cpp-cmakefiles branch February 7, 2020 21:19
@devbww
Copy link
Contributor Author

devbww commented Feb 7, 2020

Note the description was wrong. This actually upgrades to googleapis-19c4589a3cb44b3679f7b3fba88365b3d055d5f8 to match cpp-cmakefiles v0.4.1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants