-
Notifications
You must be signed in to change notification settings - Fork 14
chore: upgrade to cpp-cmakefiles v0.4.1 #1253
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1253 +/- ##
==========================================
- Coverage 94.95% 94.94% -0.01%
==========================================
Files 185 185
Lines 13825 13824 -1
==========================================
- Hits 13127 13125 -2
- Misses 698 699 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As in the other PR, I think we should update the Bazel SHA-1 version for googleapis at the same time.
Reviewed 13 of 13 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
ci/test-api/spanner_client.expected.abi.dump.gz, line 0 at r1 (raw file):
FYI, I see you update these files in almost every commit. Note that the dump is not deterministic (basically it is a perl hash table dump in ASCII format, the order of the entries can and does change from run to run), even when the contents are semantically equivalent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you say "at the same time" here. OK, I'll do that.
Reviewable status:
complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved
ci/test-api/spanner_client.expected.abi.dump.gz, line at r1 (raw file):
Previously, coryan (Carlos O'Ryan) wrote…
FYI, I see you update these files in almost every commit. Note that the dump is not deterministic (basically it is a perl hash table dump in ASCII format, the order of the entries can and does change from run to run), even when the contents are semantically equivalent.
Yeah. Unfortunately the results of the "check-api" are often long gone by the time I go to make a commit (and I'm not sure how to determine semantic equivalency without a re-run), and then I often simply forget that the dump is in the staged files. Perhaps we should just avoid updates altogether except for release time.
to match cpp-cmakefiles v0.4.1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. PTAL. Thanks.
Reviewable status: 13 of 15 files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
Note the description was wrong. This actually upgrades to googleapis-19c4589a3cb44b3679f7b3fba88365b3d055d5f8 to match cpp-cmakefiles v0.4.1. |
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)