This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
fix!: avoid single-arg forwarding c'tor #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Single-argument forwarding constructors can hide implicitly generated copy/move constructors. Even if this issue is avoided with the proper use of SFINAE, clang-tidy may still complain (incorrectly, I think). http://clang.llvm.org/extra/clang-tidy/checks/bugprone-forwarding-reference-overload.html To fix this I renamed the class `StreamOf` -> `TupleStream`. I then changed its constructor to accept to iterators instead of a single range. Then I added a `StreamOf<T>()` non-member factory function. This should make it so our existing uses all continue to work. So, this really shouldn't be much of an API break.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1233 +/- ##
==========================================
- Coverage 94.97% 94.92% -0.06%
==========================================
Files 184 184
Lines 13820 13821 +1
==========================================
- Hits 13125 13119 -6
- Misses 695 702 +7
Continue to review full report at Codecov.
|
coryan
approved these changes
Feb 3, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
|
Related to #355 |
devjgm
added a commit
to devjgm/google-cloud-cpp
that referenced
this pull request
May 7, 2020
…spanner#1233) Single-argument forwarding constructors can hide implicitly generated copy/move constructors. Even if this issue is avoided with the proper use of SFINAE, clang-tidy may still complain (incorrectly, I think). http://clang.llvm.org/extra/clang-tidy/checks/bugprone-forwarding-reference-overload.html To fix this I renamed the class `StreamOf` -> `TupleStream`. I then changed its constructor to accept to iterators instead of a single range. Then I added a `StreamOf<T>()` non-member factory function. This should make it so our existing uses all continue to work. So, this really shouldn't be much of an API break.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single-argument forwarding constructors can hide implicitly generated
copy/move constructors. Even if this issue is avoided with the proper
use of SFINAE, clang-tidy may still complain (incorrectly, I think).
http://clang.llvm.org/extra/clang-tidy/checks/bugprone-forwarding-reference-overload.html
To fix this I renamed the class
StreamOf->TupleStream. I thenchanged its constructor to accept two iterators instead of a single
range. Then I added a
StreamOf<T>()non-member factory function. Thisshould make it so our existing uses all continue to work.
So, this really shouldn't be much of an API break.
This change is