This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
doc: document how to run samples using Bazel #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the README.md generate to include instructions to build the and run the examples using Bazel.
googlebot
added
the
cla: yes
devjgm
approved these changes
Jan 30, 2020
There was a problem hiding this comment.
LGTM. Thanks.
I'm looking at the Java getting started guide here, https://cloud.google.com/spanner/docs/getting-started/java#before-you-begin
So I'm thinking that @antfitch will need to extract some parts of this info into a new Getting started in C++ doc. But that's fine, and this looks like good, clear steps that can be copied.
Codecov Report
@@ Coverage Diff @@
## master #1228 +/- ##
=========================================
+ Coverage 94.78% 94.8% +0.01%
=========================================
Files 185 185
Lines 13850 13849 -1
=========================================
+ Hits 13128 13129 +1
+ Misses 722 720 -2
Continue to review full report at Codecov.
|
devjgm
approved these changes
Jan 30, 2020
tmatsuo
approved these changes
Jan 30, 2020
devjgm
pushed a commit
to devjgm/google-cloud-cpp
that referenced
this pull request
May 7, 2020
…-cpp-spanner#1228) Update the README.md generate to include instructions to build the and run the examples using Bazel.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the README.md generate to include instructions to build the
and run the examples using Bazel.
This PR changes the target name from
//google/cloud/spanner/samples:spanner_client_samplesto
//google/cloud/spanner/samples:samplesThe latter seems easier to explain.
This fixes #1133
This change is