This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
style: cleanup use of noexcept, explicit and = default
#1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our current rule-of-thumb is to only specify `noexcept` on hand-written move constructors and assignments. So, remove two current specifications on defaulted move operators, and one on a normal constructor. Fixes googleapis#228. Reserve `explicit` for single-argument constructors. Some ctor-arity has changed over time, so some `explicit` annotations were missing or outdated. Also rewrite any `T() {}` constructor as `T() = default`.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1209 +/- ##
==========================================
+ Coverage 95.61% 95.61% +<.01%
==========================================
Files 179 179
Lines 13643 13644 +1
==========================================
+ Hits 13045 13046 +1
Misses 598 598
Continue to review full report at Codecov.
|
mr-salty
approved these changes
Jan 22, 2020
There was a problem hiding this comment.
Reviewed 14 of 14 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
devjgm
pushed a commit
to devjgm/google-cloud-cpp
that referenced
this pull request
May 7, 2020
…pis/google-cloud-cpp-spanner#1209) Our current rule-of-thumb is to only specify `noexcept` on hand-written move constructors and assignments. So, remove two current specifications on defaulted move operators, and one on a normal constructor. Fixes googleapis/google-cloud-cpp-spanner#228. Reserve `explicit` for single-argument constructors. Some ctor-arity has changed over time, so some `explicit` annotations were missing or outdated. Also rewrite any `T() {}` constructor as `T() = default`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current rule-of-thumb is to only specify
noexcepton hand-writtenmove constructors and assignments. So, remove two current specifications
on defaulted move operators, and one on a normal constructor. Fixes #228.
Reserve
explicitfor single-argument constructors. Some ctor-arityhas changed over time, so some
explicitannotations were missing oroutdated.
Also rewrite any
T() {}constructor asT() = default.This change is