Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

feat: a small script to plot benchmark results #1189

Merged
merged 2 commits into from
Jan 13, 2020
Merged

feat: a small script to plot benchmark results #1189

merged 2 commits into from
Jan 13, 2020

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jan 10, 2020

Generate pretty (maybe) plots from the benchmark data, for example:

foo


This change is Reviewable

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 10, 2020
@codecov
Copy link

codecov bot commented Jan 10, 2020

Codecov Report

Merging #1189 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1189      +/-   ##
==========================================
+ Coverage   95.63%   95.72%   +0.08%     
==========================================
  Files         174      174              
  Lines       13567    13601      +34     
==========================================
+ Hits        12975    13019      +44     
+ Misses        592      582      -10
Impacted Files Coverage Δ
google/cloud/spanner/internal/spanner_stub.cc 69.23% <0%> (-1.1%) ⬇️
google/cloud/spanner/client.cc 96.55% <0%> (-0.87%) ⬇️
.../spanner/benchmarks/multiple_rows_cpu_benchmark.cc 92.36% <0%> (-0.18%) ⬇️
...on_tests/rpc_failure_threshold_integration_test.cc 87.64% <0%> (-0.14%) ⬇️
...cloud/spanner/benchmarks/benchmarks_config_test.cc 100% <0%> (ø) ⬆️
google/cloud/spanner/timestamp_test.cc 100% <0%> (ø) ⬆️
google/cloud/spanner/database_admin_connection.h
google/cloud/spanner/instance_admin_connection.h 100% <0%> (ø)
...anner/integration_tests/client_integration_test.cc 98.47% <0%> (ø) ⬆️
google/cloud/spanner/value.h 92.8% <0%> (+0.1%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69bcc73...b0c2baa. Read the comment docs.

@coryan coryan marked this pull request as ready for review January 10, 2020 23:04

# %%
def load_benchmark_output(file):
"""Loads the output from the storage_throughput_vs_cpu_benchmark."""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: "storage_throughput_vs_cpu_benchmark" looks like a google-cloud-cpp remnant. Similarly in the file comment above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in both places.

@coryan
Copy link
Contributor Author

coryan commented Jan 13, 2020

PTAL

Copy link
Contributor

@devjgm devjgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @devbww, @mr-salty, and @scotthart)

@coryan coryan merged commit 67f73d5 into googleapis:master Jan 13, 2020
@coryan coryan deleted the add-script-to-plot-benchmark-results branch January 13, 2020 15:46
devjgm pushed a commit to devjgm/google-cloud-cpp that referenced this pull request May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants