-
Notifications
You must be signed in to change notification settings - Fork 14
feat: a small script to plot benchmark results #1189
feat: a small script to plot benchmark results #1189
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1189 +/- ##
==========================================
+ Coverage 95.63% 95.72% +0.08%
==========================================
Files 174 174
Lines 13567 13601 +34
==========================================
+ Hits 12975 13019 +44
+ Misses 592 582 -10
Continue to review full report at Codecov.
|
|
||
# %% | ||
def load_benchmark_output(file): | ||
"""Loads the output from the storage_throughput_vs_cpu_benchmark.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: "storage_throughput_vs_cpu_benchmark" looks like a google-cloud-cpp remnant. Similarly in the file comment above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in both places.
PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @devbww, @mr-salty, and @scotthart)
Generate pretty (maybe) plots from the benchmark data, for example:
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)