This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
fix: clean up / fix ClientCount logic #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1175 +/- ##
=========================================
+ Coverage 95.66% 95.7% +0.04%
=========================================
Files 175 175
Lines 13536 13535 -1
=========================================
+ Hits 12949 12954 +5
+ Misses 587 581 -6
Continue to review full report at Codecov.
|
coryan
approved these changes
Jan 9, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Removes the workaround for #1000 from the multiple rows benchmark. Since we're no longer adjusting min, and the `Config` class already validates `min_clients <= max_clients` we no longer need to do it here. Fixes two small bugs in the existing code (AFAICT): * `ClientCount` would usually (always?) return `min_clients` because `min_clients <= max_clients` is generally true. * No need to subtract 1 from `max_clients` when generating a random number.
devjgm
pushed a commit
to devjgm/google-cloud-cpp
that referenced
this pull request
May 7, 2020
…anner#1175) * fix: clean up / fix ClientCount logic Removes the workaround for googleapis/google-cloud-cpp-spanner#1000 from the multiple rows benchmark. Since we're no longer adjusting min, and the `Config` class already validates `min_clients <= max_clients` we no longer need to do it here. Fixes two small bugs in the existing code (AFAICT): * `ClientCount` would usually (always?) return `min_clients` because `min_clients <= max_clients` is generally true. * No need to subtract 1 from `max_clients` when generating a random number.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the workaround for #1000 from the multiple rows benchmark.
Since we're no longer adjusting min, and the
Configclass already validatesmin_clients <= max_clientswe no longer need to do it here.Fixes two small bugs in the existing code (AFAICT):
ClientCountwould usually (always?) returnmin_clientsbecausemin_clients <= max_clientsis generally true.max_clientswhen generating a random number.This change is