Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

feat: add CMake option to disable -Werror/-WX #1150

Merged
merged 1 commit into from Dec 15, 2019
Merged

feat: add CMake option to disable -Werror/-WX #1150

merged 1 commit into from Dec 15, 2019

Conversation

ghost
Copy link

@ghost ghost commented Dec 15, 2019

Fixes #671


This change is Reviewable

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 15, 2019
@coryan coryan added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 15, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 15, 2019
@codecov
Copy link

codecov bot commented Dec 15, 2019

Codecov Report

Merging #1150 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1150      +/-   ##
==========================================
+ Coverage    93.6%   93.66%   +0.05%     
==========================================
  Files         169      169              
  Lines       13106    13109       +3     
==========================================
+ Hits        12268    12278      +10     
+ Misses        838      831       -7
Impacted Files Coverage Δ
google/cloud/spanner/internal/polling_loop.h 91.89% <0%> (-2.71%) ⬇️
.../spanner/benchmarks/multiple_rows_cpu_benchmark.cc 64.05% <0%> (ø) ⬆️
...anner/integration_tests/client_integration_test.cc 98.97% <0%> (ø) ⬆️
...on_tests/rpc_failure_threshold_integration_test.cc 85.71% <0%> (+0.15%) ⬆️
google/cloud/spanner/samples/samples.cc 86.37% <0%> (+0.28%) ⬆️
google/cloud/spanner/client.cc 90.51% <0%> (+0.86%) ⬆️
google/cloud/spanner/internal/spanner_stub.cc 69.23% <0%> (+1.09%) ⬆️
...ud/spanner/integration_tests/client_stress_test.cc 83.33% <0%> (+1.75%) ⬆️
...loud/spanner/internal/partial_result_set_resume.cc 95.45% <0%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4628cd1...ce5f59c. Read the comment docs.

@coryan coryan merged commit 30e1e22 into googleapis:master Dec 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CMake option to disable -Werror/-WX
4 participants