This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
bug: fix year formatting in spanner::Date #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The year is required to be 0-padded to 4 digits, the month and date padding seems to be optional. Introduce a new integration test to verify data types can be written and read back.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1085 +/- ##
=========================================
- Coverage 92.02% 91.72% -0.3%
=========================================
Files 163 164 +1
Lines 11995 12022 +27
=========================================
- Hits 11038 11027 -11
- Misses 957 995 +38
Continue to review full report at Codecov.
|
devbww
approved these changes
Nov 19, 2019
| @@ -25,7 +25,7 @@ namespace internal { | |||
|
|
|||
| std::string DateToString(Date d) { | |||
| std::array<char, sizeof "-9223372036854775808-01-01"> buf; | |||
| std::snprintf(buf.data(), buf.size(), "%" PRId64 "-%02d-%02d", d.year(), | |||
| std::snprintf(buf.data(), buf.size(), "%04" PRId64 "-%02d-%02d", d.year(), | |||
| "INSERT INTO DataTypes (Id, DateValue, StringValue) " | ||
| "VALUES(@id, @date, @event)", | ||
| {{"id", Value("ReadWriteDate-1")}, | ||
| {"date", Value(Date(161, 3, 8))}, |
There was a problem hiding this comment.
Perhaps we should add a "> 9999" case to see how they handle their "YYYY: Four-digit year" edict.
There was a problem hiding this comment.
Anything over 9999 results in an error. That is consistent with the documentation; which says the valid range is 0001-01-01 to 9999-12-31
devjgm
pushed a commit
to devjgm/google-cloud-cpp
that referenced
this pull request
May 7, 2020
…p-spanner#1085) The year is required to be 0-padded to 4 digits, the month and date padding seems to be optional. Introduce a new integration test to verify data types can be written and read back.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The year is required to be 0-padded to 4 digits, the month and date
padding seems to be optional.
Introduce a new integration test to verify data types can be written and
read back.
Fixes #1083
This change is