Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add no cover for py2 collections import #426

Merged
merged 1 commit into from
Jan 18, 2020
Merged

test: add no cover for py2 collections import #426

merged 1 commit into from
Jan 18, 2020

Conversation

busunkim96
Copy link
Contributor

The coverage report is generated from the unit test session that runs last (3.7), which won't invoke the 'except' clause.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 17, 2020
@busunkim96 busunkim96 requested a review from plamut January 17, 2020 23:53
@busunkim96 busunkim96 mentioned this pull request Jan 18, 2020
Merged
plamut
plamut approved these changes Jan 18, 2020
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, since this is blocking a release, there's more value in merging now, and we can add the abovementioned test separately, should we decide for it.

@plamut plamut merged commit 0ca0ee5 into googleapis:master Jan 18, 2020
@busunkim96 busunkim96 mentioned this pull request Jan 21, 2020
Open
@yoshi-automation yoshi-automation mentioned this pull request Jan 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@busunkim96 @plamut @googlebot