Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds X509 workload cert logic #1527

Merged
merged 8 commits into from
Jun 10, 2024
Merged

feat: adds X509 workload cert logic #1527

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
47ba465
feat: adds X509 workload cert logic
aeitzman May 23, 2024
aba705c
add JSON checking, and edits comments
aeitzman May 24, 2024
28f34f6
Merge branch 'main' into x509-workload-provider
lsirac Jun 6, 2024
2e756f1
Merge branch 'main' into x509-workload-provider
aeitzman Jun 10, 2024
75121eb
Adds comment with more explanation
aeitzman Jun 10, 2024
8fe7e00
Merge branch 'main' into x509-workload-provider
aeitzman Jun 10, 2024
6adc051
fix test coverage
aeitzman Jun 10, 2024
ac8b350
Merge branch 'main' into x509-workload-provider
aeitzman Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adds comment with more explanation
  • Loading branch information
@aeitzman
aeitzman committed Jun 10, 2024
commit 75121eb2e0ae2034ded76620b34ce57c80def4a8
3 changes: 2 additions & 1 deletion google/auth/transport/_mtls_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@ def _check_dca_metadata_path(metadata_path):


def _load_json_file(path):
"""Reads and loads JSON from the given path.
"""Reads and loads JSON from the given path. Used to read both X509 workload certificate and
secure connect configurations.

Args:
path (str): the path to read from.
Expand Down