Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure with Python 3.9 due to use of deprecated collections.Mapping #418

Closed
jay0lee opened this issue Jan 8, 2020 · 0 comments · Fixed by #419
Closed

Failure with Python 3.9 due to use of deprecated collections.Mapping #418

jay0lee opened this issue Jan 8, 2020 · 0 comments · Fixed by #419
Assignees
@plamut
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@jay0lee
Copy link
Contributor

jay0lee commented Jan 8, 2020

Environment details

  • OS: Linux
  • Python version: 3.9 alpha 2
  • pip version: 19.3.1
  • google-auth version: 1.10.0

Steps to reproduce

  1. Use Python 3.9
  2. Attempt to decode an ID Token:
    google.oauth2.id_token.verify_oauth2_token()...

Expected results:
decoded ID token

Actual results:
AttributeError: module 'collections' has no attribute 'Mapping'
see full crash at:
AttributeError: module 'collections' has no attribute 'Mapping'

Further details:
collections.Mapping was moved to collections.abc.Mapping in Python 3.3 but mapped back to collections up to Python 3.8. In Python 3.9 the legacy mapping is removed so we break. See:
https://docs.python.org/3/library/collections.html#
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Jan 9, 2020
@busunkim96 busunkim96 added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Jan 13, 2020
@jay0lee jay0lee mentioned this issue Jan 17, 2020
Merged
plamut pushed a commit that referenced this issue Jan 17, 2020
@jay0lee @plamut
fix: make collections import compatible across Python versions (#419)
c5a3395 
* Use collections.abc, fixes #418

* Python 2.7 compat fix

* Fix check
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Apr 16, 2020
@joelnitta joelnitta mentioned this issue Nov 24, 2021
Open
@atagen atagen mentioned this issue Dec 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plamut plamut

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make collections import compatible across Python versions
4 participants
@plamut @jay0lee @busunkim96 @yoshi-automation