Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: style nits #528

Merged
merged 2 commits into from
Dec 17, 2020
Merged

fix: style nits #528

merged 2 commits into from
Dec 17, 2020

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Dec 17, 2020

@arithemtic1728 mostly Javadoc

@elharo elharo requested a review from a team as a code owner December 17, 2020 14:09
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 17, 2020
@elharo elharo changed the title fix style nits fix: style nits Dec 17, 2020
@codecov
Copy link

codecov bot commented Dec 17, 2020 •
edited
Loading

Codecov Report

Merging #528 (92cb8bb) into master (4090d1c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #528      +/-   ##
============================================
- Coverage     80.00%   79.98%   -0.02%     
  Complexity      420      420              
============================================
  Files            28       28              
  Lines          1965     1964       -1     
  Branches        208      208              
============================================
- Hits           1572     1571       -1     
  Misses          284      284              
  Partials        109      109
Impacted Files Coverage Δ Complexity Δ
...om/google/auth/oauth2/ImpersonatedCredentials.java 85.36% <100.00%> (-0.12%) 15.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4090d1c...92cb8bb. Read the comment docs.

yoshi-code-bot
yoshi-code-bot reviewed Dec 17, 2020
View reviewed changes
Copy link

@yoshi-code-bot yoshi-code-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • oauth2_http/java/com/google/auth/oauth2/ImpersonatedCredentials.java
    • lines 120-123
    • lines 157-160
    • lines 290-291

oauth2_http/java/com/google/auth/oauth2/ImpersonatedCredentials.java Outdated
Comment on lines 64 to 67
* another.
* The source project using ImpersonatedCredentials must enable the "IAMCredentials" API.
* Also, the target service account must grant the originating principal the "Service Account Token
* Creator" IAM role.<p>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* another.
* The source project using ImpersonatedCredentials must enable the "IAMCredentials" API.
* Also, the target service account must grant the originating principal the "Service Account Token
* Creator" IAM role.<p>
* another. The source project using ImpersonatedCredentials must enable the "IAMCredentials" API.
* Creator" IAM role.
*
* <p>Usage:

@chingor13 chingor13 merged commit 269b49d into master Dec 17, 2020
@chingor13 chingor13 deleted the cl branch December 17, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshi-code-bot yoshi-code-bot yoshi-code-bot left review comments

@chingor13 chingor13 chingor13 approved these changes

@arithmetic1728 arithmetic1728 arithmetic1728 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elharo @chingor13 @arithmetic1728 @yoshi-code-bot