-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: accept null values in request bodies #1824
Conversation
7d61a1e
to
e71bb00
Compare
This change results in many APIs that were typed as
The
Here, the input type for There are many type changes, this is just one small example of what might lurk here. |
@acchou are you bumping into any specific issues? this is an attempt to address the fact that some APIs do expect a If you were to populate |
Then these APIs should have
The page token is an opaque value, it is given by the return value of one call to the It's not a huge deal to work around this specific case, but it is odd that the APIs are defined such that I need to sanitize the value returned by changing The larger issue is that this change creates a fair amount of inconsistency in the API definitions w.r.t. use of |
BREAKING CHANGE: This fixes #1559, and runs the generator.
The following APIs have been removed:
The following APIs have been added: