Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh generated proto classes #115

Merged
merged 2 commits into from
Oct 29, 2017
Merged

Conversation

vam-google
Copy link
Contributor

@vam-google vam-google commented Oct 26, 2017

This does not include namespace change yet

@codecov-io
Copy link

codecov-io commented Oct 26, 2017

Codecov Report

Merging #115 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #115   +/-   ##
=======================================
  Coverage   90.08%   90.08%           
=======================================
  Files          32       32           
  Lines        2238     2238           
=======================================
  Hits         2016     2016           
  Misses        222      222
Impacted Files Coverage Δ
src/LongRunning/Gapic/OperationsGapicClient.php 81.09% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56b9fa9...cd16f2a. Read the comment docs.

Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jdpedrie jdpedrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple nits. looks good otherwise.

@@ -48,8 +48,10 @@
use Google\GAX\AgentHeaderDescriptor;
use Google\GAX\ApiCallable;
use Google\GAX\CallSettings;
use Google\GAX\GrpcConstants;

This comment was marked as spam.

use Google\GAX\GrpcCredentialsHelper;
use Google\GAX\PageStreamingDescriptor;
use Google\GAX\PathTemplate;

This comment was marked as spam.

This comment was marked as spam.

@@ -95,6 +97,7 @@
*/
class OperationsGapicClient
{

This comment was marked as spam.

This comment was marked as spam.

@vam-google vam-google merged commit 1019d24 into googleapis:master Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants