-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh generated proto classes #115
Conversation
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
=======================================
Coverage 90.08% 90.08%
=======================================
Files 32 32
Lines 2238 2238
=======================================
Hits 2016 2016
Misses 222 222
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple nits. looks good otherwise.
@@ -48,8 +48,10 @@ | |||
use Google\GAX\AgentHeaderDescriptor; | |||
use Google\GAX\ApiCallable; | |||
use Google\GAX\CallSettings; | |||
use Google\GAX\GrpcConstants; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
use Google\GAX\GrpcCredentialsHelper; | ||
use Google\GAX\PageStreamingDescriptor; | ||
use Google\GAX\PathTemplate; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@@ -95,6 +97,7 @@ | |||
*/ | |||
class OperationsGapicClient | |||
{ | |||
|
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This does not include namespace change yet