Skip to content
This repository was archived by the owner on Jun 28, 2022. It is now read-only.

Bug fixes for gapic config v2 parsing #2717

Merged
merged 6 commits into from
Apr 19, 2019
Merged

Bug fixes for gapic config v2 parsing #2717

merged 6 commits into from
Apr 19, 2019

Conversation

michaelbausor
Copy link
Contributor

@michaelbausor michaelbausor commented Apr 17, 2019 •
edited
Loading

  • In ProtoInterfaceModel.java, handle the case of a null Api object, which can occur when running gapic-generator with no service yaml provided
  • GapicProductConfig.java:
    • No change in logic for the gapic-config-only case
    • Switch from a proto-only case to a proto + gapic case
    • Refactor to allow two cases above to share code
    • Better error messages

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 17, 2019
@codecov
Copy link

codecov bot commented Apr 17, 2019 •
edited
Loading

Codecov Report

Merging #2717 into gapic_config_v2 will decrease coverage by 0.08%.
The diff coverage is 50%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##             gapic_config_v2    #2717      +/-   ##
=====================================================
- Coverage              86.98%   86.89%   -0.09%     
+ Complexity              5642     5640       -2     
=====================================================
  Files                    469      469              
  Lines                  22499    22515      +16     
  Branches                2436     2437       +1     
=====================================================
- Hits                   19571    19565       -6     
- Misses                  2080     2100      +20     
- Partials                 848      850       +2
Impacted Files Coverage Δ Complexity Δ
.../google/api/codegen/config/GapicProductConfig.java 76.53% <41.93%> (-3.39%) 93 <1> (-2)
...google/api/codegen/config/ProtoInterfaceModel.java 88.88% <85.71%> (-3.12%) 12 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dffe03b...3446a1e. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 17, 2019 •
edited
Loading

Codecov Report

Merging #2717 into gapic_config_v2 will increase coverage by <.01%.
The diff coverage is 93.75%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##             gapic_config_v2    #2717      +/-   ##
=====================================================
+ Coverage              86.98%   86.99%   +<.01%     
- Complexity              5642     5644       +2     
=====================================================
  Files                    469      469              
  Lines                  22499    22510      +11     
  Branches                2436     2437       +1     
=====================================================
+ Hits                   19571    19582      +11     
- Misses                  2080     2082       +2     
+ Partials                 848      846       -2
Impacted Files Coverage Δ Complexity Δ
...google/api/codegen/config/ProtoInterfaceModel.java 88.88% <85.71%> (-3.12%) 12 <0> (ø)
.../google/api/codegen/config/GapicProductConfig.java 80.45% <96%> (+0.52%) 97 <1> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dffe03b...756c58c. Read the comment docs.

@michaelbausor michaelbausor merged commit c3097f0 into googleapis:gapic_config_v2 Apr 19, 2019
@michaelbausor michaelbausor deleted the gapic_config_v2_fixes branch April 19, 2019 18:20
andreamlin added a commit that referenced this pull request Apr 22, 2019
@andreamlin
Merge in gapic_config_v2 (#2721)
c5f7f73 
* Add Gapic config v2 (#2665)
* Whittling down config_v2 (#2666)
* Add ConfigV2 Validator (#2672)
* AutoValue LongRunningConfig; always use gapic config's polling settings (#2698)
* ResourceNameOneofConfig fixes (#2704)
* Start parsing GAPIC config v2 (#2703)
* Bring back timeout millis in GAPIC config v2 (#2708)
* Resource names across different protofiles (#2711)
* Fix missing default retries (#2718)
* Bug fixes for gapic config v2 parsing (#2717)
busunkim96 pushed a commit to busunkim96/gapic-generator that referenced this pull request Nov 7, 2019
@andreamlin @busunkim96
Merge in gapic_config_v2 (googleapis#2721)
15cce16 
* Add Gapic config v2 (googleapis#2665)
* Whittling down config_v2 (googleapis#2666)
* Add ConfigV2 Validator (googleapis#2672)
* AutoValue LongRunningConfig; always use gapic config's polling settings (googleapis#2698)
* ResourceNameOneofConfig fixes (googleapis#2704)
* Start parsing GAPIC config v2 (googleapis#2703)
* Bring back timeout millis in GAPIC config v2 (googleapis#2708)
* Resource names across different protofiles (googleapis#2711)
* Fix missing default retries (googleapis#2718)
* Bug fixes for gapic config v2 parsing (googleapis#2717)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evaogbe evaogbe evaogbe approved these changes

@alexander-fenster alexander-fenster Awaiting requested review from alexander-fenster

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelbausor @evaogbe @googlebot