Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom ClientInfo #566

Closed
busunkim96 opened this issue Aug 11, 2020 · 1 comment
Closed

Allow custom ClientInfo #566

busunkim96 opened this issue Aug 11, 2020 · 1 comment
Assignees
@software-dov
Labels
generator Bugs, features, and so forth pertaining to the generated client surface priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@busunkim96
Copy link
Contributor

Clients are currently always using the default ClientInfo.

gapic-generator-python/gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/transports/base.py.j2

Line 95 in 1d08e60

client_info=_client_info,

Allow ClientInfo to be passed as a kwarg to the constructor and use it when provided.

googleapis/python-kms#37
@busunkim96 busunkim96 mentioned this issue Aug 11, 2020
Closed
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Aug 12, 2020
@software-dov software-dov added generator Bugs, features, and so forth pertaining to the generated client surface priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Aug 17, 2020
@software-dov software-dov mentioned this issue Aug 17, 2020
Merged
software-dov added a commit that referenced this issue Aug 17, 2020
@software-dov
feat: allow user-provided client info (#573)
b2e5274 
Fix for googleapis/python-kms#37, #566, and similar.
@software-dov
Copy link
Contributor

Fixed by #573

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@software-dov software-dov

Labels
generator Bugs, features, and so forth pertaining to the generated client surface priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@software-dov @busunkim96 @yoshi-automation