Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal/gengapic): add iter response access example #1468

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

noahdietz
Copy link
Collaborator

Adds some code to the paging call example that demonstrates accessing the Iterator's underlying RPC specific response type for a page. Since Iterators are generated per-resource, rather than per RPC, the Response field has to be generic, but this makes it harder for users to get at the underlying response message if there are other interesting fields.

Fixes #1467

@noahdietz noahdietz requested review from a team as code owners March 7, 2024 22:51
@noahdietz noahdietz merged commit 02e6c65 into googleapis:main Mar 8, 2024
7 checks passed
@noahdietz noahdietz deleted the iter-resp-example branch March 8, 2024 16:16
Copy link
Member

@quartzmo quartzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make getting raw responses from iterators easier
3 participants