Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update bazel-go #1381

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Jul 24, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
bazel_gazelle http_archive minor v0.31.1 -> v0.35.0
io_bazel_rules_go http_archive minor v0.40.1 -> v0.45.1

Release Notes

bazelbuild/bazel-gazelle (bazel_gazelle)

v0.35.0

Compare Source

What's Changed

New Contributors

Full Changelog: bazel-contrib/bazel-gazelle@v0.34.0...v0.35.0

v0.34.0

Compare Source

What's Changed

New Contributors

Full Changelog: bazel-contrib/bazel-gazelle@v0.33.0...v0.34.0

v0.33.0

Compare Source

What's Changed

New Contributors

Full Changelog: bazel-contrib/bazel-gazelle@v0.32.0...v0.33.0

v0.32.0

Compare Source

Starting this release, Gazelle no longer resolves Go and proto imports of Google APIs to @go_googleapis. Instead, Go packages from Google APIs will be treated as regular Go packages, and resolve to @org_golang_google_genproto, which contains the pre-generated Go code, with its version determined by Go modules. For proto files importing Google APIs proto and generating Go code, users need to:

  1. Add an http_archive rule to download Google APIs, e.g.,
http_archive(
    name = "googleapis",
    sha256 = "9d1a930e767c93c825398b8f8692eca3fe353b9aaadedfbcf1fca2282c85df88",
    strip_prefix = "googleapis-64926d52febbf298cb82a8f472ade4a3969ba922",
    urls = [
        "https://github.com/googleapis/googleapis/archive/64926d52febbf298cb82a8f472ade4a3969ba922.zip",
    ],
)

load("@​googleapis//:repository_rules.bzl", "switched_rules_by_language")

switched_rules_by_language(
    name = "com_google_googleapis_imports",
)

Note that the version of Google APIs archive needs to be compatible with the pre-generated code in @org_golang_google_genproto.

  1. Resolve the proto manually. If Gazelle is being used, directives like the following need to be added to a parent directory of the proto files:
### gazelle:resolve proto proto google/rpc/status.proto @​googleapis//google/rpc:status_proto
### gazelle:resolve proto go google/rpc/status.proto  @​org_golang_google_genproto//googleapis/rpc/status
### gazelle:resolve proto google/longrunning/operations.proto @​googleapis//google/longrunning:operations_proto
### gazelle:resolve proto go google/longrunning/operations.proto @​org_golang_google_genproto//googleapis/longrunning

What's Changed

New Contributors

Full Changelog: bazel-contrib/bazel-gazelle@v0.31.1...v0.32.0

bazelbuild/rules_go (io_bazel_rules_go)

v0.45.1

Compare Source

WORKSPACE code

load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "io_bazel_rules_go",
    sha256 = "6734a719993b1ba4ebe9806e853864395a8d3968ad27f9dd759c196b3eb3abe8",
    urls = [
        "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.45.1/rules_go-v0.45.1.zip",
        "https://github.com/bazelbuild/rules_go/releases/download/v0.45.1/rules_go-v0.45.1.zip",
    ],
)

load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies")

go_rules_dependencies()

go_register_toolchains(version = "1.21.6")

What's Changed

Full Changelog: bazel-contrib/rules_go@v0.45.0...v0.45.1

v0.45.0

Compare Source

WORKSPACE code

load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "io_bazel_rules_go",
    sha256 = "de7974538c31f76658e0d333086c69efdf6679dbc6a466ac29e65434bf47076d",
    urls = [
        "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.45.0/rules_go-v0.45.0.zip",
        "https://github.com/bazelbuild/rules_go/releases/download/v0.45.0/rules_go-v0.45.0.zip",
    ],
)

load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies")

go_rules_dependencies()

go_register_toolchains(version = "1.21.6")

What's Changed

New Contributors

Full Changelog: bazel-contrib/rules_go@v0.44.2...v0.45.0

v0.44.2

Compare Source

WORKSPACE code

load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "io_bazel_rules_go",
    sha256 = "7c76d6236b28ff695aa28cf35f95de317a9472fd1fb14ac797c9bf684f09b37c",
    urls = [
        "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.44.2/rules_go-v0.44.2.zip",
        "https://github.com/bazelbuild/rules_go/releases/download/v0.44.2/rules_go-v0.44.2.zip",
    ],
)

load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies")

go_rules_dependencies()

go_register_toolchains(version = "1.21.5")

What's Changed

Full Changelog: bazel-contrib/rules_go@v0.44.1...v0.44.2

v0.44.1

Compare Source

Why a patch release

This patch release is to include bazel-contrib/rules_go@43c40a9 which reverts a change to forcefully upgrade genproto transitively, which is causing linker failures since google.golang.org/genproto/googleapis/rpc was separated from google.golang.org/genproto

WORKSPACE code

load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "io_bazel_rules_go",
    sha256 = "b6828eb2d03bb5ef76f2077f8670b211fe792e77ddb83450ea9f887df04db9c7",
    urls = [
        "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.44.1/rules_go-v0.44.1.zip",
        "https://github.com/bazelbuild/rules_go/releases/download/v0.44.1/rules_go-v0.44.1.zip",
    ],
)

load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies")

go_rules_dependencies()

go_register_toolchains(version = "1.21.5")

What's Changed

Full Changelog: bazel-contrib/rules_go@v0.44.0...v0.44.1

v0.44.0

Compare Source

IMPORTANT CHANGES

Tests now call panic() when they timeout

This means there is a running goroutine (which will fail goleak detection)

[Goroutine 26 in state chan receive, with github.com/bazelbuild/rules_go/go/tools/bzltestutil.RegisterTimeoutHandler.func1 on top of the

This also means there may be some different behavior when calling SIGTERM directly from within a test.

For more information see: https://github.com/bazelbuild/rules_go/pull/3749

Bzlmod support for nogo

This can be added in your MODULE.bazel file:

go_sdk = use_extension("@​rules_go//go:extensions.bzl", "go_sdk")
go_sdk.download(
    name = "go_sdk",
    ...
)
go_sdk.nogo(
    nogo = "//:default_nogo",
)

For more information see https://github.com/bazelbuild/rules_go/pull/3782

WORKSPACE code

load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "io_bazel_rules_go",
    sha256 = "c8035e8ae248b56040a65ad3f0b7434712e2037e5dfdcebfe97576e620422709",
    urls = [
        "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.44.0/rules_go-v0.44.0.zip",
        "https://github.com/bazelbuild/rules_go/releases/download/v0.44.0/rules_go-v0.44.0.zip",
    ],
)

load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies")

go_rules_dependencies()

go_register_toolchains(version = "1.21.5")

What's Changed

New Contributors

Full Changelog: bazel-contrib/rules_go@v0.43.0...v0.44.0

v0.43.0

Compare Source

Breaking x/tools upgrade

This change includes a breaking upgrade to golang.org/x/tools

Please make sure to upgrade x/tools to version v0.15.0 to ensure compatibility with rules_go's NoGo.

If you need to use an older version of x/tools (v0.13.0 or earlier), apply the following patch to rules_go:
x-tools.patch

What's Changed

New Contributors

Full Changelog: bazel-contrib/rules_go@v0.42.0...v0.43.0

v0.42.0

Compare Source

What's Changed

Added patches to go_download_sdk:

Patches can now be applied to the standard library using go_download_sdk (and go_sdk.download for Bzlmod).

Example:

    go_download_sdk(
        name = "go_sdk",
        sdks = {
            "linux_amd64": (
                "go{}.linux-amd64.mirror6598503.tar.gz".format(go_version),
                "3f5c50e592d8845d30eebd08ddb9c670fd2d909e032b6c2b83ecf97afb34660c",
            ),
            "darwin_arm64": (
                "go{}.darwin-arm64.mirror6598503.tar.gz".format(go_version),
                "fbe78beee7861da09de9319498a1521bc41a8b79d3ead2218ce307b9fa5503e5",
            ),
        },
        patches = [
            "//patches:golang_osx_dns_workaround.patch",
        ],
        urls = ["https://dl.google.com/go/{}"],
        version = go_version,
    )

Other changes included:

Full Changelog: bazel-contrib/rules_go@v0.41.0...v0.42.0

WORKSPACE code

load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "io_bazel_rules_go",
    sha256 = "91585017debb61982f7054c9688857a2ad1fd823fc3f9cb05048b0025c47d023",
    urls = [
        "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.42.0/rules_go-v0.42.0.zip",
        "https://github.com/bazelbuild/rules_go/releases/download/v0.42.0/rules_go-v0.42.0.zip",
    ],
)

load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies")

go_rules_dependencies()

go_register_toolchains(version = "1.21.1")

v0.41.0

Compare Source

What's Changed

Starting this release, rules_go no longer ship with @go_googleapis repo. Together with Gazelle v0.32.0, it means that all Go code importing generated code from Google APIs will depend on @org_golang_google_genproto, which is resolved by Go modules. For proto files importing Google APIs proto and generating Go code, users need to:

  1. Add an http_archive rule to download Google APIs, e.g.,
http_archive(
    name = "googleapis",
    sha256 = "9d1a930e767c93c825398b8f8692eca3fe353b9aaadedfbcf1fca2282c85df88",
    strip_prefix = "googleapis-64926d52febbf298cb82a8f472ade4a3969ba922",
    urls = [
        "https://github.com/googleapis/googleapis/archive/64926d52febbf298cb82a8f472ade4a3969ba922.zip",
    ],
)

load("@​googleapis//:repository_rules.bzl", "switched_rules_by_language")

switched_rules_by_language(
    name = "com_google_googleapis_imports",
)

Note that the version of Google APIs archive needs to be compatible with the pre-generated code in @org_golang_google_genproto.

  1. Resolve the proto manually. If Gazelle is being used, directives like the following need to be added to a parent directory of the proto files:
### gazelle:resolve proto proto google/rpc/status.proto @​googleapis//google/rpc:status_proto
### gazelle:resolve proto go google/rpc/status.proto  @​org_golang_google_genproto//googleapis/rpc/status
### gazelle:resolve proto google/longrunning/operations.proto @​googleapis//google/longrunning:operations_proto
### gazelle:resolve proto go google/longrunning/operations.proto @​org_golang_google_genproto//googleapis/longrunning

Other changes included in this release

Full Changelog: bazel-contrib/rules_go@v0.40.1...v0.41.0

WORKSPACE code

load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "io_bazel_rules_go",
    sha256 = "278b7ff5a826f3dc10f04feaf0b70d48b68748ccd512d7f98bf442077f043fe3",
    urls = [
        "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.41.0/rules_go-v0.41.0.zip",
        "https://github.com/bazelbuild/rules_go/releases/download/v0.41.0/rules_go-v0.41.0.zip",
    ],
)

load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies")

go_rules_dependencies()

go_register_toolchains(version = "1.20.5")

Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate-bot renovate-bot requested review from a team as code owners July 24, 2023 02:03
@forking-renovate forking-renovate bot added the automerge Summon MOG for automerging label Jul 24, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2023
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summon MOG for automerging label Jul 24, 2023
@codyoss codyoss added the automerge Summon MOG for automerging label Jul 31, 2023
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summon MOG for automerging label Aug 1, 2023
@codyoss
Copy link
Member

codyoss commented Aug 7, 2023

I think we likely need to freeze these dependencies for the time being as we can't bump these in googleapis do to other compatibles between languages(at least no gazelle due to different dep resolution).

@renovate-bot renovate-bot force-pushed the renovate/bazel-go branch 4 times, most recently from a475eae to 9522155 Compare August 14, 2023 17:40
@renovate-bot renovate-bot force-pushed the renovate/bazel-go branch 2 times, most recently from caa3049 to 485a6a6 Compare September 11, 2023 15:45
@renovate-bot renovate-bot force-pushed the renovate/bazel-go branch 6 times, most recently from ac3b5af to 88a4834 Compare September 22, 2023 19:18
@renovate-bot renovate-bot force-pushed the renovate/bazel-go branch 3 times, most recently from aaaf3a7 to 6d265bb Compare October 2, 2023 20:19
@renovate-bot renovate-bot force-pushed the renovate/bazel-go branch 8 times, most recently from 661e134 to d05ff46 Compare November 8, 2023 18:34
@renovate-bot renovate-bot force-pushed the renovate/bazel-go branch 4 times, most recently from b3e9931 to dbc6547 Compare November 27, 2023 18:08
@renovate-bot renovate-bot force-pushed the renovate/bazel-go branch 4 times, most recently from 73abfca to 6083d9e Compare December 12, 2023 17:24
@renovate-bot renovate-bot force-pushed the renovate/bazel-go branch 2 times, most recently from c18694e to 6342079 Compare December 21, 2023 19:11
@renovate-bot renovate-bot force-pushed the renovate/bazel-go branch 3 times, most recently from 751e0b4 to 4cf32a7 Compare January 3, 2024 20:17
@renovate-bot renovate-bot force-pushed the renovate/bazel-go branch 2 times, most recently from 64880fb to 439d127 Compare January 19, 2024 15:08
@renovate-bot renovate-bot force-pushed the renovate/bazel-go branch 2 times, most recently from b35c470 to 3221876 Compare January 23, 2024 16:48
@quartzmo quartzmo merged commit cee85dd into googleapis:main Jan 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kokoro:force-run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants