Trace API function for trace writer project ID #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
src/trace-api.js
Outdated
| TraceAgent.prototype.getWriterProjectId = function() { | ||
| var traceWriter; | ||
| try { | ||
| traceWriter = TraceWriter.get(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
draffensperger
force-pushed
the
get-writer-project-id
branch
from
6446e09 to
18f130d
Compare
…odejs into get-writer-project-id
draffensperger
force-pushed
the
get-writer-project-id
branch
from
18f130d to
835a00c
Compare
| }); | ||
| }); | ||
|
|
||
| it('should return get the project ID if set in config', function() { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
draffensperger
force-pushed
the
get-writer-project-id
branch
from
ee273d8 to
5ab8031
Compare
matthewloring
approved these changes
Sep 2, 2017
|
No problem. If all is good, can you go ahead and merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used by the best-effort logs correlation changes to be able to format the
LogEntry.tracefield in the specifiedprojects/[PROJECT-ID]/traces/[TRACE-ID]format (per https://cloud.google.com/logging/docs/reference/v2/rest/v2/LogEntry).