Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle pg 7.16.0+ undefined Result#fields #1179

Merged
merged 1 commit into from
Jan 2, 2020
Merged

fix: handle pg 7.16.0+ undefined Result#fields #1179

merged 1 commit into from
Jan 2, 2020

Conversation

kjin
Copy link
Contributor

@kjin kjin commented Jan 2, 2020

Fixes #1177

@kjin kjin requested a review from a team January 2, 2020 19:11
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 2, 2020
@codecov
Copy link

codecov bot commented Jan 2, 2020 •
edited
Loading

Codecov Report

Merging #1179 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1179   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files          99       99           
  Lines        6513     6513           
  Branches      513      514    +1     
=======================================
  Hits         6170     6170           
  Misses        181      181           
  Partials      162      162
Impacted Files Coverage Δ
src/plugins/plugin-pg.ts 75.51% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a02ee3...25748fa. Read the comment docs.

@kjin kjin merged commit 21dbb0d into googleapis:master Jan 2, 2020
@bcoe
Copy link
Contributor

bcoe commented Jan 2, 2020

thanks @kjin 👏

@release-please release-please bot mentioned this pull request Jun 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DominicKramer DominicKramer DominicKramer approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tests are failing on main branch
4 participants
@kjin @bcoe @DominicKramer @googlebot