Expose minimist #661
Merged
Expose minimist #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antongolub
reviewed
Aug 14, 2023
antongolub
approved these changes
Aug 14, 2023
|
Could you rebase your branch? |
LionC
force-pushed
the
expose-minimist/553
branch
from
611157b to
a9fa5d8
Compare
Done :-) |
antongolub
approved these changes
Aug 15, 2023
|
No problem - looking forward to use it in out scripts. Do you already know when it will be released? |
|
Soon) |
|
It has been months, any release plan? |
Wondering this same thing? |
|
Oh, this isn't released? That explains why this wasn't working for me (despite having the apparently latest version The frustrating part is that the docs suggest that it has been released, as they show an example using |
milesrichardson
added a commit
to milesrichardson/crxmon
that referenced
this pull request
Nov 20, 2023
…t exported Despite the `zx` docs suggesting that `minimist` is exported from `zx`, that's not actually true. The code has been pushed for this feature, but it's not released to `npm` yet. Accordingly, manually install `minimist` so that we can import from it. Be careful to match the exact version (`1.2.8`) which was resolved when installing it as a dependency of `zx` (discovered through `yarn info -R minimist` and then added with `yarn add -E [email protected]`). See: google/zx#661
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #553