fix package name regex #659

[pillsilly]

Fixes #659

It's a good idea to open an issue first for discussion.

• Tests pass
• Appropriate changes to README are included in PR
• Types updated

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[antongolub]

@pillsilly, take a look at these snippets:

https://github.com/dword-design/package-name-regex/blob/master/src/index.js
https://github.com/npm/validate-npm-package-name/blob/main/lib/index.js

[antongolub]

Let the regex do this job.

[antongolub]

And let's also check another missing cases:

test('parseDeps(): import or require', async () => {
  ;[
    [`import "foo"`, { foo: 'latest' }],
    [`import "foo"`, { foo: 'latest' }],
    [`import * as bar from "foo"`, { foo: 'latest' }],
    [`import('foo')`, { foo: 'latest' }],
    [`require('foo')`, { foo: 'latest' }],
    [`require('foo/bar')`, { foo: 'latest' }],
    [`require('foo/bar.js')`, { foo: 'latest' }],
    [`require('foo-bar')`, { 'foo-bar': 'latest' }],
    [`require('foo_bar')`, { foo_bar: 'latest' }],
    [`require('@foo/bar')`, { '@foo/bar': 'latest' }],
    [`require('@foo/bar/baz')`, { '@foo/bar': 'latest' }],
    [`require('foo.js')`, { 'foo.js': 'latest' }],

    // ignores local deps
    [`import '.'`, {}],
    [`require('.')`, {}],
    [`require('..')`, {}],
    [`require('../foo.js')`, {}],
    [`require('./foo.js')`, {}],

    // ignores invalid pkg names
    [`require('_foo')`, {}],
    [`require('@')`, {}],
    [`require('@/_foo')`, {}],
    [`require('@foo')`, {}],
  ].forEach(([input, result]) => {
    assert.equal(parseDeps(input), result)
  })
})

[antongolub]

I'm still suggesting smth like

// Adapted from https://github.com/dword-design/package-name-regex/blob/5d8bfe9b6e140e3e114833e68dc1fbf500991f2c/src/index.js#L1C22-L1C22
const nameRe = /^(?<name>(@[a-z0-9-~][a-z0-9-._~]*\/)?[a-z0-9-~][a-z0-9-._~]*)\/?.*$/i

as a bit more readable and maintainable alternative.