Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Don't test on MIPS #499

Merged
merged 2 commits into from
Oct 13, 2023
Merged

[ci] Don't test on MIPS #499

merged 2 commits into from
Oct 13, 2023

Conversation

joshlf
Copy link
Member

@joshlf joshlf commented Oct 12, 2023

MIPS targets have been consistently unavailable recently, which has blocked our ability to roll the nightly toolchain.

@joshlf
[ci] Don't test on MIPS
a10b133 
MIPS targets have been consistently unavailable recently, which
has blocked our ability to roll the nightly toolchain.
@joshlf joshlf requested a review from jswrenn October 12, 2023 22:07
@joshlf joshlf enabled auto-merge October 12, 2023 22:07
jswrenn
jswrenn approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@jswrenn jswrenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, we could do -Z build-std, but if there isn't a clear reason why we should be running CI on MIPS (e.g., it has uniquely interesting properties), then cutting it out is fine.

@joshlf joshlf added this pull request to the merge queue Oct 13, 2023
@joshlf
Copy link
Member Author

joshlf commented Oct 13, 2023

Alternatively, we could do -Z build-std, but if there isn't a clear reason why we should be running CI on MIPS (e.g., it has uniquely interesting properties), then cutting it out is fine.

Yeah it was just a "let's test on as many targets as possible" thing; no reason to test on mips in particular.

Merged via the queue into main with commit 63679b1 Oct 13, 2023
@joshlf joshlf deleted the ci-remove-mips branch October 13, 2023 16:32
samuelselleck pushed a commit to samuelselleck/zerocopy that referenced this pull request Oct 13, 2023
@joshlf @samuelselleck
[ci] Don't test on MIPS (google#499)
fd09ac9 
* [ci] Don't test on MIPS

MIPS targets have been consistently unavailable recently, which
has blocked our ability to roll the nightly toolchain.

* Update ci.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jswrenn jswrenn jswrenn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshlf @jswrenn