[ci][kani] Use kani-github-action #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joshlf requesting your review in this PR. Apologies for any inconvenience caused |
joshlf
requested changes
Oct 6, 2023
|
@joshlf I have made the changes. Kindly review. |
|
@joshlf requesting for a follow up. Apologies for any inconvenience caused. |
joshlf
requested changes
Oct 9, 2023
|
@joshlf I have made the changes. Kindly review |
|
Okay everything looks good now; not sure why CI is still failing. Maybe try pulling the latest changes from |
|
@joshlf I have already rebased the branch, so there should be no conflict. |
joshlf
changed the title
kani-github-action in CI
|
@joshlf the jobs have passed!! Thanks a lot for your help and guidance |
joshlf
approved these changes
Oct 12, 2023
|
Thanks again, @Agnik7! |
|
Thanks a lot @joshlf for the opportunity and the guidance you provided!! |
samuelselleck
pushed a commit
to samuelselleck/zerocopy
that referenced
this pull request
Oct 13, 2023
* Update ci.yml * Update ci.yml * Update ci.yml --------- Co-authored-by: Joshua Liebow-Feeser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the hand-rolled Kani CI job and replaces it with the official
kani-github-action.Resolves #423