[ci] Roll pinned stable toolchain #447
Conversation
google-pr-creation-bot
force-pushed
the
roll-pinned-stable-toolchain-to-1.72.1
branch
from
92be300 to
4f6db65
Compare
There was a problem hiding this comment.
The CI failure here is interesting: The mips-unknown-linux-gnu target isn't available for 1.72.1. It's unfortunate (and surprising to me) that we can't stick to the latest stable release.
But, moreover, this limits our ability to keep a conservative MSRV. We may encounter the situation where zerocopy builds just fine on a particular toolchain, but the targets we use in CI aren't available until several versions later.
Yeah I think the move may be to skip testing on any architecture on stable or msrv (or both) as needed, and accept only testing on nightly. Right now, we can just specifically skip the mips/stable combo, and we can add a similar skip for mips/msrv combo if we need to in the future. |
google-pr-creation-bot
force-pushed
the
roll-pinned-stable-toolchain-to-1.72.1
branch
from
4f6db65 to
f136d01
Compare
MIPS targets are not available for the 1.72.1 toolchain. Prior to this commit, attempting to roll the stable toolchain to 1.72.1 was failing due to these missing targets: #447 (review) This commit skips building/testing/etc MIPS targets with the stable toolchain. This commit does not roll the stable toolchain. We want to make sure that our auto-roll procedure works, and by only disabling these target/toolchain pairs without rolling manually, we will give the auto-roller a chance to try again within 24 hours (as opposed to having to wait until the next stable toolchain release in up to six weeks).
|
Submitted #459 to disable mips/stable. Hopefully the next attempted roll after that PR lands will succeed. |
MIPS targets are not available for the 1.72.1 toolchain. Prior to this commit, attempting to roll the stable toolchain to 1.72.1 was failing due to these missing targets: #447 (review) This commit skips building/testing/etc MIPS targets with the stable toolchain. This commit does not roll the stable toolchain. We want to make sure that our auto-roll procedure works, and by only disabling these target/toolchain pairs without rolling manually, we will give the auto-roller a chance to try again within 24 hours (as opposed to having to wait until the next stable toolchain release in up to six weeks).
MIPS targets are not available for the 1.72.1 toolchain. Prior to this commit, attempting to roll the stable toolchain to 1.72.1 was failing due to these missing targets: google#447 (review) This commit skips building/testing/etc MIPS targets with the stable toolchain. This commit does not roll the stable toolchain. We want to make sure that our auto-roll procedure works, and by only disabling these target/toolchain pairs without rolling manually, we will give the auto-roller a chance to try again within 24 hours (as opposed to having to wait until the next stable toolchain release in up to six weeks).
Automated changes by create-pull-request GitHub action