[byteorder] Optimize tests; large impact on Miri #350
Merged
+52
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While they take a trivial amount of time running natively, the `test_native_endian` and `test_non_native_endian` unit tests previously took a long time to execute on Miri, slowing down local development and CI. As of the writing of this commit message, I was experiencing execution times for each test of ~60s. This commit optimizes those tests in two ways: - Use a faster RNG - When running under Miri (detected using `cfg!(miri)`), perform a single loop iteration rather than 1024 Using `time cargo miri test -- --skip ui`, I have benchmarked the execution time before this commit at ~2m36s and the time after this commit at ~8s.
joshlf
force-pushed
the
faster-byteorder-miri-test
branch
from
7453530 to
044bfba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While they take a trivial amount of time running natively, the
test_native_endianandtest_non_native_endianunit tests previously took a long time to execute on Miri, slowing down local development and CI. As of the writing of this commit message, I was experiencing execution times for each test of ~60s.This commit optimizes those tests in two ways:
cfg!(miri)), perform a single loop iteration rather than 1024Using
time cargo miri test -- --skip ui, I have benchmarked the execution time before this commit at ~2m36s and the time after this commit at ~8s.