Fix unsoundness in impl_for_transparent_wrapper! #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
force-pushed
the
impl-for-transparent-wrapper-soundness
branch
from
37305af to
3cd1658
Compare
Previously, `impl_for_transparent_wrapper!` permitted the following unsound code to compile: impl_for_transparent_wrapper!(FromBytes for AtomicBool); `impl_for_transparent_wrapper!` attempted to ensure that `AtomicBool`'s inner type implemented `FromBytes`, but failed to properly enforce this bound (it should have failed thanks to `bool: !FromBytes`). This commit simplifies `impl_for_transparent_wrapper!` and fixes this soundness hole. This fix is adapted from @josephlr's similar fix in #1091. Credit to @josephlr for discovering this soundness hole. Co-authored-by: Joe Richey <[email protected]>
joshlf
force-pushed
the
impl-for-transparent-wrapper-soundness
branch
from
3cd1658 to
f0a52b5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1585 +/- ##
=======================================
Coverage 87.70% 87.70%
=======================================
Files 15 15
Lines 5565 5565
=======================================
Hits 4881 4881
Misses 684 684 ☔ View full report in Codecov by Sentry. |
djkoloski
approved these changes
Aug 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
impl_for_transparent_wrapper!permitted the following unsound code to compile:impl_for_transparent_wrapper!(FromBytes for AtomicBool);
impl_for_transparent_wrapper!attempted to ensure thatAtomicBool's inner type implementedFromBytes, but failed to properly enforce this bound (it should have failed thanks tobool: !FromBytes).This commit simplifies
impl_for_transparent_wrapper!and fixes this soundness hole.This fix is adapted from @josephlr's similar fix in #1091. Credit to @josephlr for discovering this soundness hole.