[FromBytes] Rename some methods for consistency #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-merge was automatically disabled
May 7, 2024 16:23
Pull Request is not mergeable
joshlf
force-pushed
the
from-bytes-method-names
branch
from
e9b416b to
b3c3943
Compare
jswrenn
requested changes
May 7, 2024
src/lib.rs
Outdated
| @@ -2463,7 +2463,7 @@ pub unsafe trait FromBytes: FromZeros { | |||
| where | |||
| Self: Sized + Immutable, | |||
| { | |||
| <[Self]>::from_prefix_with_trailing_elements(bytes, count).ok() | |||
| <[Self]>::ref_from_prefix_with_trailing_elements(bytes, count).ok() | |||
There was a problem hiding this comment.
Whoa, what's up with this function signature? This should call mut_from_prefix_with_trailing_elements, and the fact that we're not points to a bug in the signature itself. This should be returning &mut [Self]s.
There was a problem hiding this comment.
Wow yeah must have been a copy+paste error at some point. Fixed.
Add `ref_` prefix to `from_{prefix,suffix}_with_trailing_elements` to be
consistent with other methods.
Makes progress on #871
joshlf
force-pushed
the
from-bytes-method-names
branch
from
b3c3943 to
5baa241
Compare
jswrenn
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ref_prefix tofrom_{prefix,suffix}_with_trailing_elementsto be consistent with other methods.Makes progress on #871