Sourcemap corrections #1750
Sourcemap corrections #1750
Conversation
| @@ -58,6 +58,12 @@ names.forEach(function(name) { | |||
| }); | |||
| print(' */'); | |||
| print(' constructor(%s) {', paramNames.join(', ')); | |||
| if (paramNames[0] === 'location') { | |||
| print('if (location) {'); | |||
There was a problem hiding this comment.
What's the perf implication?
Maybe move this into a function so it is not repeated all over.
This should be location !== null since passing undefined is an error.
There was a problem hiding this comment.
I think I should take this out and re-do this as a pass in test-utils. As the feature tests run they should create an instance of every type and those trees can be checked. Slower only for feature tests that pass. WDYT?
There was a problem hiding this comment.
Yeas. Making this a test only thing would be good.
|
Just ping me when this is ready for review |
johnjbarton
force-pushed
the
sourcemappingurl
branch
from
1acb48d to
6979661
Compare
|
PTAL |
So the |
The sourceroot code is not changed in this Pull Request. I change the description emitted by the command line help. The --source-root value can be true for basepath of the output file name, false to omit, or a string to be loaded in to the sourcemap. |
|
Ok, thanks. I just wanted to double check that documentation will be accurate once published or else it would cause more confusion. |
|
LGTM minus the location assertions. |
Correct relativePath to work for dist/js/filename case. Add test. Don't mark the placeholder parser source as input source Fixes google#1685
johnjbarton
force-pushed
the
sourcemappingurl
branch
from
e659f60 to
d22ba7a
Compare
clarify --sourceroot option meaning.
Correct relativePath to work for dist/js/filename case.
Add test.
Don't mark the placeholder parser source as input source
Fixes #1685