Upgrade json-transport to Tokio 0.2 #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for doing this! Have you talked to the maintainers of tokio serde json to see if they'll upstream your changes? |
vorot93
force-pushed
the
json-transport-upgrade
branch
3 times, most recently
from
6e7a4cd to
ed289dc
Compare
|
I have! tokio-serde has been upstreamed, tokio-serde-json is under review. |
vorot93
force-pushed
the
json-transport-upgrade
branch
from
ed289dc to
e38fb77
Compare
vorot93
force-pushed
the
json-transport-upgrade
branch
3 times, most recently
from
411e354 to
cfa175a
Compare
|
I checked with Carl on the tokio-serde-json PR -- he said he's not maintaining the repo anymore. What do you want to do? I say let's just inline the code into tarpc-json-transport; it's less than 200 LOC. |
|
I'm strongly against inlining since that code is too general for tarpc and can be used elsewhere. I'd be happy to take over and make a release though. |
|
Do you want to fork and publish a new version? |
vorot93
force-pushed
the
json-transport-upgrade
branch
from
cfa175a to
9b1af92
Compare
vorot93
force-pushed
the
json-transport-upgrade
branch
from
9b1af92 to
c9297d4
Compare
|
Let's get this merged! |
tikue
requested changes
Oct 7, 2019
tikue
approved these changes
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am temporarily using git version of
tokio-serde-json, until a newer version is released.