Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git merge smart_holder #30144

Merged
merged 3 commits into from
Aug 9, 2024
Merged

git merge smart_holder #30144

merged 3 commits into from
Aug 9, 2024

Conversation

rwgk
Copy link
Contributor

@rwgk rwgk commented Aug 9, 2024

Description

NO-OP AS EXPECTED: pybind/pybind11#4597 was forward-ported already into pybind11k (#30022).

Suggested changelog entry:

wangxf123456 and others added 3 commits August 9, 2024 13:28
* Allow specializations based on callback function return values.

* clang-tidy auto fix

* Add a test case for function specialization.

* Add test for callback function that raises Python exception.

* Fix test failures.

* style: pre-commit fixes

* Add `#define PYBIND11_HAS_TYPE_CASTER_STD_FUNCTION_SPECIALIZATIONS`

---------

Co-authored-by: Ralf W. Grosse-Kunstleve <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Copy link

google-cla bot commented Aug 9, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@rwgk rwgk marked this pull request as ready for review August 9, 2024 21:08
@rwgk
Copy link
Contributor Author

rwgk commented Aug 9, 2024

Not waiting for GHA to finish: there are no changes.

@rwgk rwgk merged commit d2b8104 into google:main Aug 9, 2024
133 checks passed
@rwgk rwgk deleted the pybind11k_merge_sh branch August 9, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants