type_caster::cast(const &) evidently does not need std::addressof()

google · Jan 23, 2024 · bcc40b2 · bcc40b2
1 parent 82c3482
commit bcc40b2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/include/pybind11/detail/smart_holder_type_casters.h b/include/pybind11/detail/smart_holder_type_casters.h
@@ -757,7 +757,7 @@ struct smart_holder_type_caster : smart_holder_type_caster_load<T>,
             || policy == return_value_policy::_clif_automatic) {
             policy = return_value_policy::copy;
         }
-        return cast(std::addressof(src), policy, parent);
+        return cast(&src, policy, parent);
         // type_caster_base END
     }
 

diff --git a/include/pybind11/detail/type_caster_base.h b/include/pybind11/detail/type_caster_base.h
@@ -1116,7 +1116,7 @@ class type_caster_base : public type_caster_generic {
             || policy == return_value_policy::automatic_reference) {
             policy = return_value_policy::copy;
         }
-        return cast(std::addressof(src), policy, parent);
+        return cast(&src, policy, parent);
     }
 
     static handle cast(itype &&src, return_value_policy, handle parent) {