-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkg] implement NuGet ecosystem parser #98
Conversation
Adds support to scan `packages.lock.json` files which are lock files for the NuGet ecosystem
Closes #51 |
This comment was marked as resolved.
This comment was marked as resolved.
Sure, done! |
Thank you for your PR. The current committers are on vacation and we will review it early next year and then release as part of the the next minor release 1.0.x release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you very much for the contribution!
/gcbrun |
/gcbrun |
@oliverchang I thought about the version verification as well already, for now I've added a check to ensure it's version Also there should probably be dedicated utilities for the parsers since right now the NuGet and Go parser makes use of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
/gcbrun |
* [pkg] implement NuGet ecosystem parser Adds support to scan `packages.lock.json` files which are lock files for the NuGet ecosystem * [pkg] add NuGet lock file format source as comment * [pkg] verify NuGet lock file version Co-authored-by: Oliver Chang <[email protected]>
* [pkg] implement NuGet ecosystem parser Adds support to scan `packages.lock.json` files which are lock files for the NuGet ecosystem * [pkg] add NuGet lock file format source as comment * [pkg] verify NuGet lock file version Co-authored-by: Oliver Chang <[email protected]>
Adds support to scan
packages.lock.json
files which are lock filesfor the NuGet ecosystem.
Closes #51