Maximum severity rating for each Group object in JSON output #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Omri Bornstein <[email protected]>
Signed-off-by: Omri Bornstein <[email protected]>
G-Rath
approved these changes
Feb 14, 2024
| @@ -4,6 +4,7 @@ import ( | |||
| "sort" | |||
| "strings" | |||
|
|
|||
| out "github.com/google/osv-scanner/internal/output" | |||
There was a problem hiding this comment.
happy for this to be done in a follow up pr sometime, but ideally it would be better to rename the variable
There was a problem hiding this comment.
No worries, I'll rename the output variables to results.
…ents name conflict with internal output package Signed-off-by: Omri Bornstein <[email protected]>
another-rex
reviewed
Feb 14, 2024
… struct property Signed-off-by: Omri Bornstein <[email protected]>
|
@another-rex @G-Rath thank you both for the thoughtful feedback. |
|
I'll get to writing the |
Signed-off-by: Omri Bornstein <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #805 +/- ##
===========================================
- Coverage 79.98% 58.96% -21.02%
===========================================
Files 91 116 +25
Lines 6214 8442 +2228
===========================================
+ Hits 4970 4978 +8
- Misses 1040 3261 +2221
+ Partials 204 203 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MaxSeverityfunction if this is required for this issue.