Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify return codes to return 1 if any vulnerability related error #677

Merged
merged 5 commits into from
Nov 27, 2023

Conversation

another-rex
Copy link
Collaborator

Fixes #676

  • Return 0 if there are no findings or errors.
  • Return 1 if there are any findings (license or vulns).
  • Return 128 if no packages are found.

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8c5634d) 78.50% compared to head (621291b) 78.74%.

Files Patch % Lines
cmd/osv-reporter/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #677      +/-   ##
==========================================
+ Coverage   78.50%   78.74%   +0.24%     
==========================================
  Files          82       82              
  Lines        5890     5853      -37     
==========================================
- Hits         4624     4609      -15     
+ Misses       1068     1046      -22     
  Partials      198      198              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@josieang josieang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

pkg/osvscanner/osvscanner.go Show resolved Hide resolved
Copy link
Collaborator

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Rex!

@another-rex another-rex merged commit aa3ca89 into google:main Nov 27, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify return codes
4 participants