Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove some extra newlines in sarif report #607

Merged
merged 6 commits into from
Oct 25, 2023
Merged

fix: remove some extra newlines in sarif report #607

merged 6 commits into from
Oct 25, 2023

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Oct 25, 2023

This is a bit nicer semantically imo and it also means the report is slightly smaller which is good.

I've not bothered dealing with the trailing , when there are multiple IDs as it seems like that would be a lot more work relative to the other changes so I don't think it's worth it

@codecov-commenter
Copy link

Codecov Report

Merging #607 (0742c08) into main (32ad454) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #607   +/-   ##
=======================================
  Coverage   80.61%   80.61%           
=======================================
  Files          78       78           
  Lines        5334     5334           
=======================================
  Hits         4300     4300           
  Misses        866      866           
  Partials      168      168           
Files Coverage Δ
internal/output/sarif.go 90.42% <ø> (ø)

@another-rex another-rex merged commit 3ed8963 into google:main Oct 25, 2023
@G-Rath G-Rath deleted the reduce-newlines branch October 25, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants