Refactor reporter to interfaces #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverchang
approved these changes
Apr 26, 2023
G-Rath
reviewed
May 24, 2023
|
|
||
| cli.VersionPrinter = func(ctx *cli.Context) { | ||
| r = reporter.NewReporter(ctx.App.Writer, ctx.App.ErrWriter, "") | ||
| r = reporter.NewTableReporter(stdout, stderr, false) |
There was a problem hiding this comment.
This should not have been changed because it causes tests to be flakey - see #166
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reporter has been refactored to be an interface with various implementations. Based on the idea from Michael here: #341 (comment)
Want to get some feedback on whether this is worth changing or not.
I'm also not sure if we should have the different reporter types public here, or make them private and have the users of the library provide their own implementations of Reporter.