Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(output): display base image info on HTML and table outputs #1513

Merged
merged 12 commits into from
Jan 22, 2025

Conversation

hogo6002
Copy link
Contributor

@hogo6002 hogo6002 commented Jan 21, 2025

Resolves #1410

Adds detailed base image and layer data for HTML output: https://hogo6002.github.io/mvp/
Screenshot 2025-01-21 at 2 29 36 PM
image

Adds layer tracing for table output:
Screenshot 2025-01-21 at 1 51 28 PM

@hogo6002 hogo6002 requested a review from another-rex January 21, 2025 03:26
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 93.12977% with 9 lines in your changes missing coverage. Please review.

Project coverage is 69.07%. Comparing base (630fa81) to head (e6a3b8b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/output/output_result.go 94.16% 6 Missing and 1 partial ⚠️
internal/output/html.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1513      +/-   ##
==========================================
+ Coverage   69.03%   69.07%   +0.03%     
==========================================
  Files         197      197              
  Lines       18804    18864      +60     
==========================================
+ Hits        12982    13030      +48     
- Misses       5119     5131      +12     
  Partials      703      703              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hogo6002 hogo6002 changed the title feat(output): display base image info on HTML output feat(output): display base image info on HTML and table outputs Jan 21, 2025
internal/output/output_result.go Show resolved Hide resolved
internal/output/output_result.go Outdated Show resolved Hide resolved
internal/output/output_result.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some small suggestions from a UI perspective.

I'll let @another-rex handle the code review side of things :)

internal/output/html/base_image_template.gohtml Outdated Show resolved Hide resolved
@hogo6002 hogo6002 enabled auto-merge (squash) January 22, 2025 03:27
@hogo6002 hogo6002 merged commit 905d53b into google:main Jan 22, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance container scanning results with base image and comprehensive layer data
4 participants