Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(guided remediation): npm workspaces devDeps in in-place strategy #1512

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

michaelkedar
Copy link
Member

devDependencies can be declared in a workspace, which is not a direct dependency (root -> workspace -> dev). Made the IsDev check that in-place uses also check these so that --ignore-dev works properly for in-place with npm workspace.
(--ignore-dev still doesn't behave correctly for relax with workspaces, but relax doesn't really work with workspaces anyway)

Also fixed a potential panic with in-place & private registries that don't behave as expected w.r.t. optionalDependencies being in regular dependencies

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 68.98%. Comparing base (16deb2f) to head (964eb17).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/remediation/in_place.go 0.00% 3 Missing ⚠️
internal/resolution/dependency_chain.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1512      +/-   ##
==========================================
+ Coverage   66.66%   68.98%   +2.32%     
==========================================
  Files         200      197       -3     
  Lines       19006    18800     -206     
==========================================
+ Hits        12670    12970     +300     
+ Misses       5655     5127     -528     
- Partials      681      703      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelkedar michaelkedar merged commit 399c409 into google:main Jan 21, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants