refactor: Licence matcher #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1491 +/- ##
==========================================
+ Coverage 66.84% 66.95% +0.10%
==========================================
Files 198 198
Lines 18650 18652 +2
==========================================
+ Hits 12467 12488 +21
+ Misses 5498 5483 -15
+ Partials 685 681 -4 ☔ View full report in Codecov by Sentry. |
cuixq
approved these changes
Jan 13, 2025
| // DepsDevLicenseMatcher implements the LicenseMatcher interface with a deps.dev client. | ||
| // It sends out requests for every package version and does not perform caching. | ||
| type DepsDevLicenseMatcher struct { | ||
| Client *datasource.DepsDevAPIClient |
There was a problem hiding this comment.
I think clients in internal/resolution/datasource meant to be used for dependency resolution. considering we are going to use DepsDevAPICleint for license matching as well, shall we move resolution/datasource to datasource?
There was a problem hiding this comment.
yeah probably a good idea, I'll create an issue for it to keep track, we can do it in a followup PR.
oliverchang
approved these changes
Jan 13, 2025
another-rex
added a commit
that referenced
this pull request
Jan 15, 2025
I am attempting to split a big refactor PR into several small pieces, this is part 4, which just removes the need for the osv package from many places since we are replacing it with the osvdev package. This mostly means user agent need to be passed in via the client instead of being pulled from a global variable (this was already started in part 3: #1491 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also partially removes the global user agent variable to be specificly passed in for every client.
Majority of the code in licencematcher.go is migrated from the deleted license.go file.