fix: apply go version override to _all_ instances of the stdlib
#1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1278 +/- ##
==========================================
+ Coverage 68.43% 68.44% +0.01%
==========================================
Files 175 175
Lines 16798 16798
==========================================
+ Hits 11495 11498 +3
+ Misses 4673 4671 -2
+ Partials 630 629 -1 ☔ View full report in Codecov by Sentry. |
another-rex
approved these changes
Sep 26, 2024
|
Thanks for a quick fix @G-Rath ! |
G-Rath
force-pushed
the
config/go-override
branch
from
613fa6a to
fad3e1b
Compare
G-Rath
force-pushed
the
config/go-override
branch
from
fad3e1b to
3b683d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we assume that there'll only ever be one occurence of
stdlibwhen overriding the Go version but really there can be an occurrence pergo.modfileResolves #1273