Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move Maven utility to a separate package #1193

Merged
merged 7 commits into from
Aug 22, 2024
Merged

Conversation

cuixq
Copy link
Contributor

@cuixq cuixq commented Aug 21, 2024

#1045

Considering that we want to support native Maven registry, we need MergeMavenParents from internal/manifest in internal/resolution/client, however internal/manifest imports internal/resolution/client for DependencyClient for dependency resolution, and this causes an import cycle.

This PR moves the Maven utility in internal/manifest to a separate package internal/utility/maven.

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 65.42056% with 37 lines in your changes missing coverage. Please review.

Project coverage is 65.89%. Comparing base (dd4eef1) to head (84fd6e6).
Report is 2 commits behind head on main.

Files Patch % Lines
internal/utility/maven/maven.go 58.90% 21 Missing and 9 partials ⚠️
internal/resolution/manifest/maven.go 84.00% 0 Missing and 4 partials ⚠️
internal/manifest/maven.go 33.33% 0 Missing and 2 partials ⚠️
internal/remediation/override.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1193   +/-   ##
=======================================
  Coverage   65.89%   65.89%           
=======================================
  Files         167      168    +1     
  Lines       14072    14072           
=======================================
  Hits         9273     9273           
  Misses       4289     4289           
  Partials      510      510           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cuixq cuixq marked this pull request as ready for review August 21, 2024 01:34
@cuixq cuixq requested review from michaelkedar and another-rex and removed request for michaelkedar August 21, 2024 01:34
@cuixq cuixq merged commit 35b36a3 into google:main Aug 22, 2024
13 checks passed
@cuixq cuixq deleted the refactor branch August 22, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants