Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proxygen] Set rpath properly #2880

Merged
merged 1 commit into from
Sep 23, 2019
Merged

Conversation

jonathanmetzman
Copy link
Contributor

Speculative fix for proxygen.

@jonathanmetzman
Copy link
Contributor Author

CC @mhlakhani

@inferno-chromium
Copy link
Collaborator

Thanks a ton @jonathanmetzman !

@jonathanmetzman jonathanmetzman merged commit d488ec1 into master Sep 23, 2019
@jonathanmetzman jonathanmetzman deleted the jonathanmetzman-patch-1 branch September 23, 2019 17:43
@jonathanmetzman
Copy link
Contributor Author

I'll kick off another build to see if this fix worked.

@inferno-chromium
Copy link
Collaborator

@jonathanmetzman - it might be interesting to add this trick on https://google.github.io/oss-fuzz/further-reading/fuzzer-environment/ ? Thoughts ? this patchelf stuff keeps coming every now and then.

@mhlakhani
Copy link
Contributor

thanks for putting up the patch so quickly!

@jonathanmetzman
Copy link
Contributor Author

thanks for putting up the patch so quickly!

No problem!

it might be interesting to add this trick on https://google.github.io/oss-fuzz/further-reading/fuzzer-environment/ ? Thoughts ? this patchelf stuff keeps coming every now and then.

Sure, doing it now.
An alternative would be adding this some kind of linker flags for OSS-Fuzz projects should use (kind of what $LIB_FUZZING_ENGINE should be IMO)

@jonathanmetzman
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants