Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: Roll OUR_LLVM_REVISION #11714
infra: Roll OUR_LLVM_REVISION #11714
Changes from 60 commits
d7624af
e040cda
445af02
32cc42f
f5c348a
7c7b5fe
7426bbe
9734c6d
831a115
59acb96
9edffe3
7cecde1
b572e75
af99d25
facb3da
99eb541
63ad15e
73f101e
36cfd0d
497dbc7
1a37f77
6560eff
0371eb1
0e04b75
e8dece5
1b5c0a9
ac94e64
67511e4
e681e68
0fe67e0
d6a2a3e
5f4bc6d
a01baa6
f136d02
39fa5d7
9ac77b2
dbc0a35
a51f59b
cb50b3a
1431b42
68ac6c7
31053b8
7add704
a8f0448
b0b3c5c
4b102bb
e80d234
61ade86
ac41c22
77418cd
c243fda
730b595
83510f6
3900a29
77e2416
05f9912
8411086
6fbacb2
5fe9a77
21d3761
fd20335
488a9eb
a440a47
a996285
a996f20
44c695d
ac95179
1fa5335
d083d8b
659d1e6
8a14a29
601eb97
32fee35
1614e2f
0f72c7f
53d96ab
5e168fe
27148ba
5b56d71
7271062
7977bcd
314d7d9
672117a
e2fffee
2a40864
cf1c790
767c7d3
321ebca
c6a6d86
cdd10ad
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder to what extend it makes sense to enumerate each warnings that is turned into an error. This may require additional effort to maintain, going forward. Also, it may become verbose. The following remaining projects turn warnings into errors, and cause themselves to fail to build with clang-18:
If the goal is to be developer friendly and aggressively try to compile any code (even if it is not fully conformant) into a fuzz binary, an easier way would be to globally set
no-error
here (for all errors).The hope would be that any erroneous code would then not show up as a build failure, but as a runtime-sanitizer failure. I think this is reasonable, but please let me know what you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the last flag wins (https://godbolt.org/z/64oqzYfoE),
so that won't quite work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I am aware.
It works for all projects that do not append error flags, which seems to be all (or at least the majority) of the projects for now.
Are you trying to say overwriting the error flags should not be done in the infra?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just saying that it will generally only work for projects that don't adjust warning flags themselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a clear goal in mind, just that widely breaking projects is bad but smaller breakages or locally fixing a few projects is OK. So if it will cause wide breakage, we should avoid it.
:-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jup, I think the current warning downgrades are fine, to allow to compile most projects.
I'll follow-up in the days after merge of this pull to un-pin the projects listed in #11714 (comment) to work around rare compile error types.
Next year, or so, the
-Wno-error=
could be revisited and some could maybe removed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be really incredible if you could leave a comment on each of these pinnings where we link back to this PR, and in this PR you could explain how to find the build failure logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't preserve all failure logs, so my recommendation would be to create a follow-up pull request to un-pin all projects and then run a trial build to gather the all current failure logs in one run. Then, I can add a link to that run in all affected projects.