Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: OUR_LLVM_REVISION=llvmorg-18-init-14420-gea3a3b25 #11707

Closed
wants to merge 28 commits into from

Conversation

maflcko
Copy link
Contributor

@maflcko maflcko commented Mar 18, 2024

Basically #8108 with small fixups, to properly set CC and CXX and -S for the libc++ i386 and msan builds

@maflcko
Copy link
Contributor Author

maflcko commented Mar 18, 2024

Ah, I guess CI is expected to fail.

Can someone please initiate a gcbrun trial build?

@maflcko
Copy link
Contributor Author

maflcko commented Mar 19, 2024

I checked locally that the build completes for some random projects, via:

infra/base-images/all.sh
python3 infra/helper.py build_fuzzers --sanitizer undefined  --engine libfuzzer tokio
python3 infra/helper.py build_fuzzers --sanitizer address    --engine afl curl
python3 infra/helper.py build_fuzzers --sanitizer address  --engine libfuzzer --architecture i386 curl
python3 infra/helper.py build_fuzzers --sanitizer memory  --engine libfuzzer curl

@maflcko
Copy link
Contributor Author

maflcko commented Mar 19, 2024

@DavidKorczynski
Copy link
Collaborator

Thanks @maflcko

Do you know the details of the error that occurs?:

2024-03-19T11:16:30.8624867Z #5 14.52   adding 'pyinstaller-5.0.1.dist-info/RECORD'
2024-03-19T11:16:30.8625058Z #5 14.52   removing build/bdist.linux-x86_64/wheel
2024-03-19T11:16:30.8625453Z #5 14.52   No precompiled bootloader found or compile forced. Trying to compile the bootloader for you ...
2024-03-19T11:16:30.8625818Z #5 14.52 ERROR: Could not build wheels for atheris which use PEP 517 and cannot be installed directly
2024-03-19T11:16:30.8626120Z #5 14.52 WARNING: You are using pip version 19.2.3, however version 24.0 is available.
2024-03-19T11:16:30.8626473Z #5 14.52 You should consider upgrading via the 'pip install --upgrade pip' command.
2024-03-19T11:16:30.8626867Z #5 ERROR: process "/bin/sh -c install_python.sh" did not complete successfully: exit code: 1
2024-03-19T11:16:30.8626967Z ------
2024-03-19T11:16:30.8627081Z  > [2/2] RUN install_python.sh:
2024-03-19T11:16:30.8627306Z 14.52   adding 'pyinstaller-5.0.1.dist-info/METADATA'
2024-03-19T11:16:30.8627504Z 14.52   adding 'pyinstaller-5.0.1.dist-info/WHEEL'
2024-03-19T11:16:30.8627755Z 14.52   adding 'pyinstaller-5.0.1.dist-info/entry_points.txt'
2024-03-19T11:16:30.8627982Z 14.52   adding 'pyinstaller-5.0.1.dist-info/top_level.txt'
2024-03-19T11:16:30.8628250Z 14.52   adding 'pyinstaller-5.0.1.dist-info/RECORD'
2024-03-19T11:16:30.8628436Z 14.52   removing build/bdist.linux-x86_64/wheel
2024-03-19T11:16:30.8628818Z 14.52   No precompiled bootloader found or compile forced. Trying to compile the bootloader for you ...
2024-03-19T11:16:30.8629179Z 14.52 ERROR: Could not build wheels for atheris which use PEP 517 and cannot be installed directly
2024-03-19T11:16:30.8629462Z 14.52 WARNING: You are using pip version 19.2.3, however version 24.0 is available.
2024-03-19T11:16:30.8629812Z 14.52 You should consider upgrading via the 'pip install --upgrade pip' command.
2024-03-19T11:16:30.8629909Z ------
2024-03-19T11:16:30.8629999Z Dockerfile:19
2024-03-19T11:16:30.8630113Z --------------------
2024-03-19T11:16:30.8630362Z   17 |     FROM gcr.io/oss-fuzz-base/base-builder
2024-03-19T11:16:30.8630456Z   18 |     
2024-03-19T11:16:30.8630570Z   19 | >>> RUN install_python.sh
2024-03-19T11:16:30.8630658Z   20 |     
2024-03-19T11:16:30.8630770Z --------------------
2024-03-19T11:16:30.8631230Z ERROR: failed to solve: process "/bin/sh -c install_python.sh" did not complete successfully: exit code: 1
2024-03-19T11:16:30.8631351Z ERROR:__main__:Docker build failed.
2024-03-19T11:16:30.8631490Z Pulling and building base images first.

@maflcko
Copy link
Contributor Author

maflcko commented Mar 19, 2024

Yes, the error only happens in the CI, because it pulls the old base-clang image (as opposed to building the current one). See https://github.com/google/oss-fuzz/actions/runs/8341860860/job/22828806330?pr=11707#step:7:1563 . Thus, the libclang_rt.fuzzer.a will not be present, when the environment variable is set before install_python.sh. See https://github.com/google/oss-fuzz/actions/runs/8341860860/job/22828806330?pr=11707#step:7:19279 and https://github.com/google/oss-fuzz/actions/runs/8341860860/job/22828806330?pr=11707#step:7:27017

Not building the base-clang is done, because I don't think there are enough resources in GitHub Actions to compile clang?

If you run locally, it should pass.

@DavidKorczynski
Copy link
Collaborator

/gcbrun trial_build.py all --fuzzing-engines libfuzzer --sanitizers coverage address

@maflcko
Copy link
Contributor Author

maflcko commented Mar 20, 2024

The error is that my branch name is not a valid docker tag:

Step #1: Step #0: invalid argument "gcr.io/oss-fuzz-base/base-image-testing-2403-roll-clang-" for "-t, --tag" flag: invalid reference format

@maflcko maflcko closed this Mar 20, 2024
@maflcko maflcko deleted the 2403-roll-clang- branch March 20, 2024 07:21
@maflcko
Copy link
Contributor Author

maflcko commented Mar 20, 2024

Renamed branch to #11714

oliverchang pushed a commit that referenced this pull request Apr 29, 2024
From #11707 with the branch
renamed

---------

Co-authored-by: Jonathan Metzman <[email protected]>
Co-authored-by: MarcoFalke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants